Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two little documentation issues in Modules file #27737

Closed
wants to merge 1 commit into from
Closed

Fixed two little documentation issues in Modules file #27737

wants to merge 1 commit into from

Conversation

Alex-Temny
Copy link
Contributor

Fixed 2 little issues of API documentation ("Modules" file) as described in issue #27640

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels May 16, 2019
@trivikr
Copy link
Member

trivikr commented May 16, 2019

@Alex-Temny Thank you for your contribution

Looks like the email used in the commit is not registered with GitHub
Either register that email with GitHub or or change the other by following these steps

@Alex-Temny
Copy link
Contributor Author

@trivikr
Hi.
I can't verify that old email, because it was deleted by me some time ago,
and Google don't allow me to register it again.

I've tried to follow instructions given on the page you specified.
I understand how to change email.
But it scares a liitle bit me that the page says "Editing Past Commits Rewrites History!"
given in "Editing the Author of Past Commits" section there.

So, I can change my email to the correct one locally on my PC.
I'm amateur with git/github.
I don't undestand,
shoud I fork master branch again, fix those 2 little issues again and make a new PR now?

@trivikr
Copy link
Member

trivikr commented May 17, 2019

Yup, it's safe to rewrite just your commit as changes are going to be in the branch of your fork
For future reference, setting up email is mentioned in step 1 of setting local environment in Contributing.md

@Alex-Temny
Copy link
Contributor Author

thanks

@Trott
Copy link
Member

Trott commented May 25, 2019

Should this be closed in favor of #27853?

@Alex-Temny
Copy link
Contributor Author

hi.
yes, please, close this.
I made a mistake in this PR with my local environment and I made a new one (#27853).
I understand that there should be some ways to update this PR (like it is described in https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md), but that was too complicated for me.
So, I made a new one. sorry.

@Trott Trott closed this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants