Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check napi_get_reference_value() during finalization #27470

Closed

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added test Issues and PRs related to the tests. node-api Issues and PRs related to the Node-API. labels Apr 29, 2019
@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this file uses NAPI_ASSERT(). Maybe this change should as well, for consistency? No big deal either way though.

@addaleax
Copy link
Member Author

@cjihrig NAPI_ASSERT() throws a JS error, which isn’t possible here – it’s just unfortunate naming…

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented May 1, 2019

Landed in e1c838e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants