Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix http/bench-parser.js #27360

Closed
wants to merge 1 commit into from
Closed

benchmark: fix http/bench-parser.js #27360

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 23, 2019

Follow up for #25094

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3335

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels Apr 23, 2019
@refack refack requested review from Trott and mmarchini April 23, 2019 13:00
@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 23, 2019
@refack
Copy link
Contributor Author

refack commented Apr 23, 2019 •
edited
Loading

This fixes a failing test in the benchmark suite, so I suggest we fast track this.
Please 👍 if you concur.

@Flarna
Copy link
Member

Flarna commented Apr 23, 2019

dup to #27359?

@refack
Copy link
Contributor Author

refack commented Apr 23, 2019

Closed as dup

@refack refack closed this Apr 23, 2019
@refack refack added abandoned and removed flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 23, 2019
@refack refack deleted the fix-http-benchmark branch April 23, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Awaiting requested review from Trott

@mmarchini mmarchini Awaiting requested review from mmarchini

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refack @nodejs-github-bot @Flarna