Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.x] deps: V8: backport 61f4c22 #27259

Closed

Commits on Apr 16, 2019

  1. deps: V8: backport 61f4c22

    The differences to the original patch are the replacement of
    `i::IsIdentifier...()` with `unicode_cache_.IsIdentifier...()`,
    because the former is not available on Node.js v11.x, as well
    as the omitted `no_gc` argument for `GetFlatContent()`.
    
    Original commit message:
    
        Assume flat string when checking CompileFunctionInContext arguments.
    
        R=jkummerow@chromium.org
    
        Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc
        Reviewed-on: https://chromium-review.googlesource.com/c/1388533
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#58562}
    
    Refs: v8/v8@61f4c22
    Fixes: nodejs#27256
    addaleax committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    a06297a View commit details
    Browse the repository at this point in the history