Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: allow leaked global check to be skipped #27239

Closed
wants to merge 1 commit into from
Closed

test: allow leaked global check to be skipped #27239

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 15, 2019

This simplifies the process of running tests on different versions of Node, which might have a different set of global variables.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@cjihrig
test: allow leaked global check to be skipped
22e0b09 
This simplifies the process of running tests on different
versions of Node, which might have a different set of
global variables.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 15, 2019
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3259

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 15, 2019

cc: @Trott

Trott
Trott approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit: Probably worth adding a note to test/common/README.md about it?

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 15, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22453/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22520/

@danbev
Copy link
Contributor

danbev commented Apr 19, 2019

Landed in 57ab3b5.

@danbev danbev closed this Apr 19, 2019
danbev pushed a commit that referenced this pull request Apr 19, 2019
@cjihrig @danbev
test: allow leaked global check to be skipped
57ab3b5 
This simplifies the process of running tests on different
versions of Node, which might have a different set of
global variables.

PR-URL: #27239
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@cjihrig cjihrig deleted the globals branch April 26, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @danbev @jasnell @Trott @addaleax @lpinca @BridgeAR