Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: inline onwriteStateUpdate() #27203

Closed
wants to merge 1 commit into from
Closed

stream: inline onwriteStateUpdate() #27203

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 12, 2019

The function is very simple and is only called from onwrite().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lpinca
stream: inline onwriteStateUpdate()
5f486e9 
The function is very simple and is only called from `onwrite()`.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3237

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Apr 12, 2019
@lpinca
Copy link
Member Author

lpinca commented Apr 12, 2019

Mostly a cosmetic change but I think it improves readability. No need to jump to the onwriteStateUpdate() definition.

@lpinca
Copy link
Member Author

lpinca commented Apr 12, 2019

onwriteError() could also be inlined. I think it was split into multiple functions due to the old limit on the number of characters in the body that prevented functions from being optimized. AFAIK that limit no longer exists.

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22402/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22452/

@danbev
Copy link
Contributor

danbev commented Apr 16, 2019

Landed in 53e0f63.

@danbev danbev closed this Apr 16, 2019
danbev pushed a commit that referenced this pull request Apr 16, 2019
@lpinca @danbev
stream: inline onwriteStateUpdate()
53e0f63 
The function is very simple and is only called from `onwrite()`.

PR-URL: #27203
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@lpinca lpinca deleted the inline/onwrite-state-update branch April 27, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@shisama shisama shisama approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lpinca @nodejs-github-bot @danbev @cjihrig @BridgeAR @shisama @ZYSzys