Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise Collaborator material in GOVERNANCE.md #27103

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 5, 2019

  • Reduce passive voice
  • Shorter and simpler sentences
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

* Reduce passive voice
* Shorter and simpler sentences
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 5, 2019
@vsemozhetbyt vsemozhetbyt added the doc Issues and PRs related to the documentations. label Apr 5, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2019
@Trott
Copy link
Member Author

Trott commented Apr 8, 2019

Landed in 557bd86

@Trott Trott closed this Apr 8, 2019
Trott added a commit to Trott/io.js that referenced this pull request Apr 8, 2019
* Reduce passive voice
* Shorter and simpler sentences

PR-URL: nodejs#27103
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@Trott Trott deleted the collab-revise branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants