Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: minor cleanup and improvements #27034

Closed
wants to merge 1 commit into from
Closed

async_hooks: minor cleanup and improvements #27034

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Mar 31, 2019 •
edited
Loading

Cleanup some code and make the emit hooks very slightly faster.

CI: https://ci.nodejs.org/job/node-test-pull-request/22080/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@apapirovski
async_hooks: minor cleanup and improvements
3983202 
Cleanup some code and make the emit hooks very slightly faster.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3128

@nodejs-github-bot nodejs-github-bot added the async_hooks Issues and PRs related to the async hooks subsystem. label Mar 31, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22080/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 3, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 4, 2019
@apapirovski @BridgeAR
async_hooks: minor cleanup and improvements
04355ef 
Cleanup some code and make the emit hooks very slightly faster.

PR-URL: nodejs#27034
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR
Copy link
Member

BridgeAR commented Apr 4, 2019

Landed in 04355ef 🎉

@BridgeAR BridgeAR closed this Apr 4, 2019
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@apapirovski @BethGriggs
async_hooks: minor cleanup and improvements
ca7c4f4 
Cleanup some code and make the emit hooks very slightly faster.

PR-URL: #27034
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@apapirovski @BethGriggs
async_hooks: minor cleanup and improvements
d688a93 
Cleanup some code and make the emit hooks very slightly faster.

PR-URL: #27034
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apapirovski @nodejs-github-bot @BridgeAR @jasnell @ZYSzys