Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: improve callbackify #26893

Closed
wants to merge 3 commits into from
Closed

util: improve callbackify #26893

wants to merge 3 commits into from

Commits on Mar 24, 2019

  1. util: increase function length when using callbackify() 

    The returned function from `util.callbackify()` should increase the
`length` property by one due to the added callback.
    @BridgeAR
    BridgeAR committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    693515f View commit details
    Browse the repository at this point in the history

  2. util: rename callbackified function 

    This makes sure the function returned by `util.callbackify()` has a
new name that is not identical to the inputs function name.
    @BridgeAR
    BridgeAR committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    386340b View commit details
    Browse the repository at this point in the history

  3. util: don't set the prototype of callbackified functions 

    Using `util.callbackify()` should not set the prototype for the
returned function to the one from the input function. It could cause
confusion while debugging otherwise.
    @BridgeAR
    BridgeAR committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    a15dd01 View commit details
    Browse the repository at this point in the history