Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove usage of require('util') #26779

Closed
wants to merge 1 commit into from
Closed

lib: remove usage of require('util') #26779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/encoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ class TextEncoder {
});
obj.encoding = this.encoding;
// Lazy to avoid circular dependency
return require('util').inspect(obj, opts);
return require('internal/util/inspect').inspect(obj, opts);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was possible to change

node/lib/internal/encoding.js

Line 21 in 1329d0a

customInspectSymbol: inspect

to

customInspectSymbol: <something else>

I could put require('internal/util/inspect').inspect together with all the top level imports.

}
}

Expand Down Expand Up @@ -530,7 +530,7 @@ function makeTextDecoderJS() {
obj[kHandle] = this[kHandle];
}
// Lazy to avoid circular dependency
return require('util').inspect(obj, opts);
return require('internal/util/inspect').inspect(obj, opts);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/nodejs/node/pull/26779/files#r266906412

}
}));
Object.defineProperties(TextDecoder.prototype, {
Expand Down