Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: reduce internal usage require('util') #26750

Closed
wants to merge 1 commit into from
Closed

assert: reduce internal usage require('util') #26750

wants to merge 1 commit into from

Conversation

toshi1127
Copy link
Contributor

Remove the usage of public require('util'), as described in issue:
#26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Mar 18, 2019
@toshi1127 toshi1127 mentioned this pull request Mar 19, 2019
Closed
@ZYSzys
Copy link
Member

ZYSzys commented Mar 22, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21751/

@BridgeAR BridgeAR changed the title assertion_error: reduce internal usage of public require of util assert: reduce internal usage require('util') Mar 22, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 22, 2019

Resume: https://ci.nodejs.org/job/node-test-pull-request/21776/

@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR
Copy link
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21802/

@ZYSzys
Copy link
Member

ZYSzys commented Mar 24, 2019

Landed in b2b8741 🎉

@ZYSzys ZYSzys closed this Mar 24, 2019
ZYSzys pushed a commit that referenced this pull request Mar 24, 2019
@toshi1127 @ZYSzys
assert: reduce internal usage of public require of util
b2b8741 
PR-URL: #26750
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@toshi1127 @targos
assert: reduce internal usage of public require of util
3a0961b 
PR-URL: nodejs#26750
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@toshi1127 @targos
assert: reduce internal usage of public require of util
a2d2756 
PR-URL: #26750
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toshi1127 @ZYSzys @BridgeAR @jasnell @nodejs-github-bot