Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor Environment::GetCurrent(isolate) usage #26376

Closed
wants to merge 5 commits into from
Closed

src: refactor Environment::GetCurrent(isolate) usage #26376

wants to merge 5 commits into from

Commits on Mar 1, 2019

  1. src: refactor Environment::GetCurrent(isolate) usage 

    Do not require an explicit `HandleScope`, or the ability to create
one, when using `Environment::GetCurrent()`.

`isolate->InContext()` is used as an indicator that it is probably
okay to create a `HandleScope`, see also the short discussion in
nodejs#25775 (review).
    @addaleax
    addaleax committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    3509d74 View commit details
    Browse the repository at this point in the history

  2. src: prefer to get Environment from Context 

    We explicitly store the context anyway, and can skip the
extra steps introduced in `Environment::GetCurrent()`.
    @addaleax
    addaleax committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    d85419d View commit details
    Browse the repository at this point in the history

  3. src: allow running tasks without Environment 

    There is no real reason to assume that V8 tasks would have
to run in a Node.js `Context`.
    @addaleax
    addaleax committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    322041b View commit details
    Browse the repository at this point in the history

  4. src: forbid handle allocations from Platform tasks 

    Platform tasks should have their own handle scopes, rather than
leak into outer ones.
    @addaleax
    addaleax committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    6b766af View commit details
    Browse the repository at this point in the history

  5. fixup! src: prefer to get Environment from Context

    @addaleax
    addaleax committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    7f99bbb View commit details
    Browse the repository at this point in the history