Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit deprecation identifier info in Collaborator Guide #26372

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 1, 2019

Edit the deprecation identifier material in the Collaborator Guide for
simplicity and clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Edit the deprecation identifier material in the Collaborator Guide for
simplicity and clarity.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 1, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2019
@Trott
Copy link
Member Author

Trott commented Mar 3, 2019

Landed in d773311

@Trott Trott closed this Mar 3, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 3, 2019
Edit the deprecation identifier material in the Collaborator Guide for
simplicity and clarity.

PR-URL: nodejs#26372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
Edit the deprecation identifier material in the Collaborator Guide for
simplicity and clarity.

PR-URL: #26372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
Edit the deprecation identifier material in the Collaborator Guide for
simplicity and clarity.

PR-URL: #26372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
@Trott Trott deleted the edit-deprecation-identifier branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants