Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move AsyncResource impl out of public header #26348

Closed
wants to merge 1 commit into from

Commits on Mar 22, 2019

  1. src: move AsyncResource impl out of public header

    Implementing the methods out-of-line (i.e., not inline) means we can fix
    bugs and have already compiled add-ons pick up the fixes automatically,
    something that doesn't work when the methods are inline because then
    they get compiled into the add-on instead of the node binary.
    bnoordhuis committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    f934c22 View commit details
    Browse the repository at this point in the history