worker: provide process.execArgv #26267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@addaleax sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
c++
addaleax
added
process
joyeecheung
approved these changes
Feb 23, 2019
|
do docs need to be updated for the execArgv option on the Worker constructor? |
cjihrig
approved these changes
Feb 23, 2019
addaleax
force-pushed
the
worker-exec-argv
branch
from
0381d5b
to
1da935e
Compare
|
@jasnell Yup, added a note for that in 1da935e. |
addaleax
added
the
author ready
BridgeAR
reviewed
Mar 1, 2019
jasnell
approved these changes
Mar 1, 2019
Provide `process.execArgv`. If an `execArgv` option is passed to the `Worker` constructor, that option is used as its value; if not, the parent’s `process.execArgv` is inherited (since that also goes for the actual options in that case).
addaleax
force-pushed
the
worker-exec-argv
branch
from
a8514d1
to
7cfad4c
Compare
|
Landed in f65b4af |
addaleax
added a commit
that referenced
this pull request
Mar 2, 2019
Provide `process.execArgv`. If an `execArgv` option is passed to the `Worker` constructor, that option is used as its value; if not, the parent’s `process.execArgv` is inherited (since that also goes for the actual options in that case). PR-URL: #26267 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
that referenced
this pull request
Mar 2, 2019
Provide `process.execArgv`. If an `execArgv` option is passed to the `Worker` constructor, that option is used as its value; if not, the parent’s `process.execArgv` is inherited (since that also goes for the actual options in that case). PR-URL: #26267 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
process.execArgv. If anexecArgvoption is passed to theWorkerconstructor, that option is used as its value; if not,the parent’s
process.execArgvis inherited (since that also goesfor the actual options in that case).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes