Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-worker-ref-onexit #26170

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-worker-ref-onexit #26170

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 17, 2019 •
edited
Loading

This was very flaky on AIX (over 10 % failure rate).

Stress test for this PR: https://ci.nodejs.org/job/node-stress-single-test/2158/ (0/359 failures – definitely better than 10 % :))
CI: https://ci.nodejs.org/job/node-test-commit/25940/

Please 👍 this comment to approve fast-tracking.

Fixes: #26167

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support. labels Feb 17, 2019
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2645/pipeline

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 17, 2019
@addaleax
Copy link
Member Author

Landed in 2da7ff5

@addaleax addaleax closed this Feb 17, 2019
@addaleax addaleax deleted the fix-worker-ref-on-exit branch February 17, 2019 23:11
addaleax added a commit that referenced this pull request Feb 17, 2019
@addaleax
test: fix flaky test-worker-ref-onexit
2da7ff5 
Fixes: #26167

PR-URL: #26170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
addaleax added a commit that referenced this pull request Feb 18, 2019
@addaleax
test: fix flaky test-worker-ref-onexit
ebdc16e 
Fixes: #26167

PR-URL: #26170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@addaleax @rvagg
test: fix flaky test-worker-ref-onexit
441b545 
Fixes: #26167

PR-URL: #26170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky test-worker-ref-onexit
6 participants
@addaleax @nodejs-github-bot @Trott @lpinca @richardlau @BethGriggs