doc: remove deprecation definition in Collaborator Guide #26157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Collaborator Guide links to a definition of "deprecation" but also quotes it extensively. Remove the extensive quotes.
devsnek
approved these changes
Feb 16, 2019
richardlau
approved these changes
Feb 17, 2019
Blame points to #20788 😛 |
Trott
added
the
author ready
antsmartian
approved these changes
Feb 17, 2019
cjihrig
approved these changes
Feb 17, 2019
jasnell
approved these changes
Feb 18, 2019
lpinca
approved these changes
Feb 18, 2019
|
Landed in 0ebff65 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 19, 2019
The Collaborator Guide links to a definition of "deprecation" but also quotes it extensively. Remove the extensive quotes. PR-URL: nodejs#26157 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 19, 2019
The Collaborator Guide links to a definition of "deprecation" but also quotes it extensively. Remove the extensive quotes. PR-URL: #26157 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
The Collaborator Guide links to a definition of "deprecation" but also quotes it extensively. Remove the extensive quotes. PR-URL: #26157 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Collaborator Guide links to a definition of "deprecation" but also
quotes it extensively. Remove the extensive quotes.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes