Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: use ‘real’ atomics #26156

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Use actual atomic operations instead of things that are
named as if they were atomics, but aren’t.

Refs: #26100

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Use actual atomic operations instead of things that are
named as if they were atomics, but aren’t.

Refs: nodejs#26100
@addaleax addaleax added the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Feb 16, 2019
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 16, 2019
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was totally atomic already because... uh... they ran on computers made of atoms!

@addaleax
Copy link
Member Author

@addaleax
Copy link
Member Author

Landed in 1c71c0c

@addaleax addaleax closed this Feb 19, 2019
@addaleax addaleax deleted the no-pretend-atomics branch February 19, 2019 18:57
addaleax added a commit that referenced this pull request Feb 19, 2019
Use actual atomic operations instead of things that are
named as if they were atomics, but aren’t.

Refs: #26100

PR-URL: #26156
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
addaleax added a commit that referenced this pull request Feb 21, 2019
Use actual atomic operations instead of things that are
named as if they were atomics, but aren’t.

Refs: #26100

PR-URL: #26156
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Use actual atomic operations instead of things that are
named as if they were atomics, but aren’t.

Refs: #26100

PR-URL: #26156
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants