Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update acorn to 6.1.0 #26102

Closed
wants to merge 1 commit into from
Closed

deps: update acorn to 6.1.0 #26102

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
Copy link
Contributor

danbev commented Feb 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20859/

@danbev
Copy link
Contributor

danbev commented Feb 20, 2019 •
edited
Loading

Re-run of failing node-test-commit-freebsd (✔️)
Re-run of failing node-test-commit-arm (✔️)

@gengjiawen
Copy link
Member Author

gengjiawen commented Feb 27, 2019 •
edited
Loading

@danbev Can you import this one and #26158 too ? Thanks.

@danbev
Copy link
Contributor

danbev commented Feb 27, 2019

Landed in 64a1581.

@danbev danbev closed this Feb 27, 2019
danbev pushed a commit that referenced this pull request Feb 27, 2019
@gengjiawen @danbev
deps: update acorn to 6.1.0
64a1581 
PR-URL: #26102
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gengjiawen
Copy link
Member Author

Thanks.

@gengjiawen gengjiawen deleted the bump_acorn branch February 27, 2019 08:41
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@gengjiawen @addaleax
deps: update acorn to 6.1.0
c8d30a7 
PR-URL: #26102
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjiawen @danbev @TimothyGu @BridgeAR