Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use same parameter name in node_report.cc #26046

Closed
wants to merge 1 commit into from
Closed

src: use same parameter name in node_report.cc #26046

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Fix clang-tidy issue, use same parameter name, see

node/src/node_report.cc

Line 233 in 9c86e74

TIME_TYPE* tm_struct) {

Also found that function declaration is located in .cc file. Any special reason for this file ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 11, 2019
@joyeecheung
Copy link
Member

Also found that function declaration is located in .cc file. Any special reason for this file ?

All the methods in node_report.cc are forward-declared so that the definitions can be placed arbitrarily, though that's not a style we normally use in this code base and more of the style of the original npm module.

@danbev
Copy link
Contributor

danbev commented Feb 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20773/

@addaleax
Copy link
Member

Landed in 66942d7 :)

@addaleax addaleax closed this Feb 15, 2019
addaleax pushed a commit that referenced this pull request Feb 15, 2019
@gengjiawen @addaleax
src: use same parameter name in node_report.cc
66942d7 
PR-URL: #26046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Feb 16, 2019
@gengjiawen @addaleax
src: use same parameter name in node_report.cc
26f181e 
PR-URL: #26046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gengjiawen @rvagg
src: use same parameter name in node_report.cc
497d9d8 
PR-URL: #26046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @joyeecheung @danbev @addaleax @jasnell @nodejs-github-bot