Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add PASS to outcomes in debug mode #25698

Closed
wants to merge 1 commit into from
Closed

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jan 25, 2019

Currently, when configuring with --debug there is a lot of output from
tests that use console.log. I believe that this was not the case prior
to commit deaddd2 ("tools,test: add list of slow tests").

The motivation for this commit is that I find it difficult to
distinguish real errors from tests that log errors when running in debug
mode. This commit updates test/root.status to also include a PASS status
so that this output is not displayed. If a tests fails then running the
test directly will show the output.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 25, 2019
@danbev
Copy link
Contributor Author

danbev commented Jan 25, 2019

@refack refack added tools Issues and PRs related to the tools directory. python PRs and issues that require attention from people who are familiar with Python. labels Jan 25, 2019
@refack
Copy link
Contributor

refack commented Jan 25, 2019

I'll take a look at the code to see if it makes sense to make this change in code and not in configuration...

@addaleax
Copy link
Member

Thank you, I just stumbled over this myself :)

Currently, when configuring with --debug there is a lot of output from
tests that use console.log. I believe that this was not the case prior
to commit deaddd2 ("tools,test: add
list of slow tests").

The motivation for this commit is that I find it difficult to
distinguish real errors from tests that log errors when running in debug
mode. This commit updates test/root.status to also include a PASS status
so that this output is not displayed. If a tests fails then running the
test directly will show the output.
@danbev
Copy link
Contributor Author

danbev commented Jan 30, 2019

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2019
@danbev
Copy link
Contributor Author

danbev commented Feb 1, 2019

@refack Did you get a chance to look at a code change for this? If not, could we land this and perhaps you could follow up separate PR?

@richardlau
Copy link
Member

#25868

@danbev
Copy link
Contributor Author

danbev commented Feb 1, 2019

@richardlau Thanks, closing this favour of #25868

@danbev danbev closed this Feb 1, 2019
@refack
Copy link
Contributor

refack commented Feb 1, 2019

H/T to @hashseed to following up (while reading my mind)

@refack refack added superseded and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 1, 2019
@hashseed
Copy link
Member

hashseed commented Feb 1, 2019

Ran into this while testing my gn build :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants