Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable marking of failing coverage tests #25671

Closed
wants to merge 6 commits into from
Closed

test: enable marking of failing coverage tests #25671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a45db5
test: enable marking of failing coverage tests
mhdawson Jan 22, 2019
58013ef
squash: allow FAIL and CRASH to avoid yellow
mhdawson Jan 23, 2019
9d0c898
squash: allow new tests to pass until ci job added
mhdawson Jan 23, 2019
c27dd17
squash: address comments
mhdawson Jan 24, 2019
a48bc9f
squash: address comments
mhdawson Jan 24, 2019
f7b5b67
squash: address comments
mhdawson Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ coverage-test: coverage-build
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/gen/*.gcda
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*.gcda
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/tracing/*.gcda
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage $(MAKE) $(COVTESTS)
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage \
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS)
$(MAKE) coverage-report-js
-(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \
--gcov-exclude='.*usr' -v -r Release/obj.target \
Expand Down Expand Up @@ -277,7 +278,7 @@ coverage-run-js:
$(RM) -r out/$(BUILDTYPE)/.coverage
$(MAKE) coverage-build-js
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage CI_SKIP_TESTS=$(COV_SKIP_TESTS) \
$(MAKE) jstest
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) jstest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would probably make sense to also specify:

FLAKY_TESTS="dontcare"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k will add.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on @refack's comment I'll leave out setting dontcare completely for now.

$(MAKE) coverage-report-js

.PHONY: test
Expand Down
4 changes: 4 additions & 0 deletions test/root.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,7 @@ sequential/test-inspector-port-cluster: SLOW
sequential/test-net-bytes-per-incoming-chunk-overhead: SLOW
sequential/test-pipe: SLOW
sequential/test-util-debug: SLOW

[$type==coverage]
js-native-api/test_function/test: PASS,FAIL,CRASH
js-native-api/test_general/testFinalizer: PASS,FAIL,CRASH
2 changes: 1 addition & 1 deletion tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,7 +1388,7 @@ def BuildOptions():
help='Send SIGABRT instead of SIGTERM to kill processes that time out',
default=False, action="store_true", dest="abort_on_timeout")
result.add_option("--type",
help="Type of build (simple, fips)",
help="Type of build (simple, fips, coverage)",
default=None)
return result

Expand Down