Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make compress_json python3 compatible #25582

Closed
wants to merge 1 commit into from
Closed

build: make compress_json python3 compatible #25582

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

This patch replaces a usage of map with list comprehension,
which makes the script Python 3 compatiable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

cc @nodejs/python @cclauss

@thefourtheye
build: make compress_json python3 compatible
1667570 
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.
@nodejs-github-bot
Copy link
Collaborator

@thefourtheye build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2299/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 19, 2019
@refack refack added python PRs and issues that require attention from people who are familiar with Python. build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol labels Jan 19, 2019
@refack
Copy link
Contributor

refack commented Jan 19, 2019

I'm looking at the history, and it seems like this is a node-core only tool. Maybe we can eliminate it.

/CC @nodejs/v8-inspector

@thefourtheye
Copy link
Contributor Author

@refack Good call. If we can get rid of this, one less file to maintain.

@bnoordhuis
Copy link
Member

it seems like this is a node-core only tool. Maybe we can eliminate it.

What is the question? I introduced it to shrink the size of the embedded JSON. Currently it reduces its size from about 140k to 15k.

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20357/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2019
@danbev
Copy link
Contributor

danbev commented Jan 28, 2019 •
edited
Loading

Re-run of failing node-test-commit-linux-containered ✔️

@danbev
Copy link
Contributor

danbev commented Jan 28, 2019

Landed in b31b84d.

@danbev danbev closed this Jan 28, 2019
danbev pushed a commit that referenced this pull request Jan 28, 2019
@thefourtheye @danbev
build: make compress_json python3 compatible
b31b84d 
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.

PR-URL: #25582
Reviewed-By: Refael Ackermann <refack@gmail.com>
@thefourtheye thefourtheye deleted the make-compress-json-python3-compatible branch January 28, 2019 13:01
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@thefourtheye @addaleax
build: make compress_json python3 compatible
bc81a68 
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.

PR-URL: #25582
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
targos added a commit that referenced this pull request Jan 30, 2019
@targos
2019-01-30, Version 11.9.0 (Current)
7556b0b 
Notable changes:

* deps:
  * OpenSSL has been updated to 1.1.1a.
    #25582

PR-URL: #25802
targos added a commit that referenced this pull request Jan 30, 2019
@targos
2019-01-30, Version 11.9.0 (Current)
8e24451 
Notable changes:

* deps:
  * OpenSSL has been updated to 1.1.1a, which is API/ABI compatible with
    the previous OpenSSL 1.1.0j. Note that while OpenSSL 1.1.1a supports
    TLS1.3, Node.js still does not.
    #25582

PR-URL: #25802
targos added a commit that referenced this pull request Jan 30, 2019
@targos
2019-01-30, Version 11.9.0 (Current)
9e08386 
Notable changes:

* deps:
  * OpenSSL has been updated to 1.1.1a, which is API/ABI compatible with
    the previous OpenSSL 1.1.0j. Note that while OpenSSL 1.1.1a supports
    TLS1.3, Node.js still does not.
    #25582

PR-URL: #25802
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@thefourtheye @BethGriggs
build: make compress_json python3 compatible
3d55b61 
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.

PR-URL: #25582
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@thefourtheye @BethGriggs
build: make compress_json python3 compatible
faf45a7 
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.

PR-URL: #25582
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@thefourtheye @MylesBorins
build: make compress_json python3 compatible
99a653e 
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.

PR-URL: #25582
Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
This was referenced May 29, 2019
Closed
Closed
BaochengSu pushed a commit to BaochengSu/node that referenced this pull request Oct 20, 2020
@thefourtheye @BaochengSu
build: make compress_json python3 compatible
c9586ad 
This patch replaces a usage of `map` with list comprehension,
which makes the script Python 3 compatiable.

PR-URL: nodejs#25582
Reviewed-By: Refael Ackermann <refack@gmail.com>
(cherry picked from commit b31b84d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thefourtheye @nodejs-github-bot @refack @bnoordhuis @addaleax @danbev @cclauss