-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix module loading error for AIX 7.1 #25418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethGriggs
approved these changes
Jan 9, 2019
gireeshpunathil
approved these changes
Jan 9, 2019
richardlau
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 9, 2019
cjihrig
approved these changes
Jan 9, 2019
gdams
approved these changes
Jan 9, 2019
mhdawson
approved these changes
Jan 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AIX 7.1 appears to return a different error message compared to AIX 6.1. PR-URL: nodejs#25418 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau
force-pushed
the
alternative-aix-message
branch
from
January 11, 2019 17:38
e36a65d
to
fbab26f
Compare
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
AIX 7.1 appears to return a different error message compared to AIX 6.1. PR-URL: #25418 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
AIX 7.1 appears to return a different error message compared to AIX 6.1. PR-URL: nodejs#25418 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Mar 15, 2019
AIX 7.1 appears to return a different error message compared to AIX 6.1. PR-URL: #25418 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 15, 2019
AIX 7.1 appears to return a different error message compared to AIX 6.1. PR-URL: #25418 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aix
Issues and PRs related to the AIX platform.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the current
master
on AIX 7.1 andgcc 6.3.0
I get the following test failure:I've verified using
python
(not all of the AIX machines that I have access to have the necessary environment set up to build/run Node.js) that the error message fromdlopen
is different on AIX 7.1 compared to AIX 6.1.AIX 7.1:
AIX 6.1:
This PR adds another allowed error message for AIX to allow the test to pass.
Note that the CI AIX machines are currently AIX 6.1.
cc @nodejs/platform-aix
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes