test: remove test/pummel/test-http-client-reconnect-bug.js #25387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-http-client-reconnect-bug depends on `http.createClient()` which was removed in Node.js 7.0.0. The test was added way back in commit 30b0522 for a bug fixed in Node.js 0.1.27 in early 2010. We've apparently been fine with it failing since at least Node.js 7.0.0 which at this time is more than 2 years ago. Remove this test.
|
(Pummel tests are not exercised in CI yet. Lite CI should be sufficient here.) |
danbev
approved these changes
Jan 8, 2019
jasnell
approved these changes
Jan 8, 2019
Trott
added
the
author ready
BridgeAR
approved these changes
Jan 10, 2019
|
Landed in 0a11f1b |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 10, 2019
test-http-client-reconnect-bug depends on `http.createClient()` which was removed in Node.js 7.0.0. The test was added way back in commit 30b0522 for a bug fixed in Node.js 0.1.27 in early 2010. We've apparently been fine with it failing since at least Node.js 7.0.0 which at this time is more than 2 years ago. Remove this test. PR-URL: nodejs#25387 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
test-http-client-reconnect-bug depends on `http.createClient()` which was removed in Node.js 7.0.0. The test was added way back in commit 30b0522 for a bug fixed in Node.js 0.1.27 in early 2010. We've apparently been fine with it failing since at least Node.js 7.0.0 which at this time is more than 2 years ago. Remove this test. PR-URL: #25387 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
test-http-client-reconnect-bug depends on `http.createClient()` which was removed in Node.js 7.0.0. The test was added way back in commit 30b0522 for a bug fixed in Node.js 0.1.27 in early 2010. We've apparently been fine with it failing since at least Node.js 7.0.0 which at this time is more than 2 years ago. Remove this test. PR-URL: nodejs#25387 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
test-http-client-reconnect-bug depends on `http.createClient()` which was removed in Node.js 7.0.0. The test was added way back in commit 30b0522 for a bug fixed in Node.js 0.1.27 in early 2010. We've apparently been fine with it failing since at least Node.js 7.0.0 which at this time is more than 2 years ago. Remove this test. PR-URL: #25387 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
test-http-client-reconnect-bug depends on `http.createClient()` which was removed in Node.js 7.0.0. The test was added way back in commit 30b0522 for a bug fixed in Node.js 0.1.27 in early 2010. We've apparently been fine with it failing since at least Node.js 7.0.0 which at this time is more than 2 years ago. Remove this test. PR-URL: #25387 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
test-http-client-reconnect-bug depends on `http.createClient()` which was removed in Node.js 7.0.0. The test was added way back in commit 30b0522 for a bug fixed in Node.js 0.1.27 in early 2010. We've apparently been fine with it failing since at least Node.js 7.0.0 which at this time is more than 2 years ago. Remove this test. PR-URL: #25387 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-http-client-reconnect-bug depends on
http.createClient()whichwas removed in Node.js 7.0.0. The test was added way back in commit
30b0522 for a bug fixed in Node.js
0.1.27 in early 2010. We've apparently been fine with it failing since
at least Node.js 7.0.0 which at this time is more than 2 years ago.
Remove this test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes