src: use internalBinding('config').hasInspector in JS land
#25291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
TimothyGu
approved these changes
Dec 31, 2018
|
What I liked about |
lpinca
approved these changes
Jan 1, 2019
lpinca
reviewed
Jan 1, 2019
lib/internal/bootstrap/cache.js
Outdated
| @@ -33,7 +33,7 @@ const cannotUseCache = [ | |||
|
|
|||
| // Skip modules that cannot be required when they are not | |||
| // built into the binary. | |||
| if (process.config.variables.v8_enable_inspector !== 1) { | |||
| if (hasInspector) { | |||
There was a problem hiding this comment.
I think this should be !hasInspector
|
@jdalton I personally would not mind if there is an alias for |
jasnell
approved these changes
Jan 1, 2019
Instead of `process.config.variables.v8_enable_inspector`
which depends on the variable name in gyp files, or detecting
`internalBinding('inspector').Connection`.
joyeecheung
force-pushed
the
has-inspector
branch
from
89178d2 to
b249b07
Compare
|
Rebased and fixed test: https://ci.nodejs.org/job/node-test-pull-request/19910/ |
|
SmartOS ran out of memory. Resume: https://ci.nodejs.org/job/node-test-pull-request/19912/ |
|
Landed in b22c86e |
joyeecheung
added a commit
that referenced
this pull request
Jan 4, 2019
Instead of `process.config.variables.v8_enable_inspector`
which depends on the variable name in gyp files, or detecting
`internalBinding('inspector').Connection`.
PR-URL: #25291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
|
Opened #25343 about |
|
Should this be backported to |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Instead of `process.config.variables.v8_enable_inspector`
which depends on the variable name in gyp files, or detecting
`internalBinding('inspector').Connection`.
PR-URL: nodejs#25291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 15, 2019
Instead of `process.config.variables.v8_enable_inspector`
which depends on the variable name in gyp files, or detecting
`internalBinding('inspector').Connection`.
PR-URL: #25291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Instead of `process.config.variables.v8_enable_inspector`
which depends on the variable name in gyp files, or detecting
`internalBinding('inspector').Connection`.
PR-URL: nodejs#25291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 17, 2019
Instead of `process.config.variables.v8_enable_inspector`
which depends on the variable name in gyp files, or detecting
`internalBinding('inspector').Connection`.
PR-URL: nodejs#25291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
process.config.variables.v8_enable_inspectorwhich depends on the variable name in gyp files, or detecting
internalBinding('inspector').Connection.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes