Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set umask for tests #25229

Closed
wants to merge 2 commits into from
Closed

test: set umask for tests #25229

wants to merge 2 commits into from

Commits on Jan 9, 2019

  1. test: set umask for tests 

    nodejs#25213 proposes setting umask in the
Python test runner to avoid spurious test failures when running from a
shell with a restrictive umask. This is a good idea, but will only fix
the issue for tests run with the Python runner. Set it in
`common/index.js` as well so that it fixes it even when tests are run
directly with a `node` binary, bypassing the Python test runner.
    @Trott
    Trott committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    c3c94c0 View commit details
    Browse the repository at this point in the history

  2. fixup! test: set umask for tests

    @Trott
    Trott committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    8036a8b View commit details
    Browse the repository at this point in the history