worker: Fix workers isolation

doc/api/util.md

@@ -449,10 +449,6 @@ changes:
   * `showProxy` {boolean} If `true`, then objects and functions that are
     `Proxy` objects will be introspected to show their `target` and `handler`
     objects. **Default:** `false`.
-    <!--
-    TODO(BridgeAR): Deprecate `maxArrayLength` and replace it with
-                    `maxEntries`.
-    -->
   * `maxArrayLength` {integer} Specifies the maximum number of `Array`,
     [`TypedArray`][], [`WeakMap`][] and [`WeakSet`][] elements to include when
     formatting. Set to `null` or `Infinity` to show all elements. Set to `0` or

lib/buffer.js

@@ -48,9 +48,7 @@ const {
   isArrayBufferView,
   isUint8Array
 } = require('internal/util/types');
-const {
-  pendingDeprecation
-} = internalBinding('config');
+
 const {
   ERR_BUFFER_OUT_OF_BOUNDS,
   ERR_OUT_OF_RANGE,
@@ -138,7 +136,7 @@ const bufferWarning = 'Buffer() is deprecated due to security and usability ' +
 function showFlaggedDeprecation() {
   if (bufferWarningAlreadyEmitted ||
       ++nodeModulesCheckCounter > 10000 ||
-      (!pendingDeprecation &&
+      (!require('internal/options').getOptionValue('--pending-deprecation') &&
        isInsideNodeModules())) {
     // We don't emit a warning, because we either:
     // - Already did so, or

lib/internal/bootstrap/node.js

@@ -176,7 +176,7 @@ function startup() {
   {
     // Install legacy getters on the `util` binding for typechecking.
     // TODO(addaleax): Turn into a full runtime deprecation.
-    const { pendingDeprecation } = internalBinding('config');
+    const pendingDeprecation = getOptionValue('--pending-deprecation');
     const utilBinding = internalBinding('util');
     const types = internalBinding('types');
     for (const name of [

lib/internal/http2/util.js

@@ -246,43 +246,43 @@ function getDefaultSettings() {
   const flags = settingsBuffer[IDX_SETTINGS_FLAGS];
 
   if ((flags & (1 << IDX_SETTINGS_HEADER_TABLE_SIZE)) ===
-      (1 << IDX_SETTINGS_HEADER_TABLE_SIZE)) {
+    (1 << IDX_SETTINGS_HEADER_TABLE_SIZE)) {
     holder.headerTableSize =
       settingsBuffer[IDX_SETTINGS_HEADER_TABLE_SIZE];
   }
 
   if ((flags & (1 << IDX_SETTINGS_ENABLE_PUSH)) ===
-      (1 << IDX_SETTINGS_ENABLE_PUSH)) {
+    (1 << IDX_SETTINGS_ENABLE_PUSH)) {
     holder.enablePush =
       settingsBuffer[IDX_SETTINGS_ENABLE_PUSH] === 1;
   }
 
   if ((flags & (1 << IDX_SETTINGS_INITIAL_WINDOW_SIZE)) ===
-      (1 << IDX_SETTINGS_INITIAL_WINDOW_SIZE)) {
+    (1 << IDX_SETTINGS_INITIAL_WINDOW_SIZE)) {
     holder.initialWindowSize =
       settingsBuffer[IDX_SETTINGS_INITIAL_WINDOW_SIZE];
   }
 
   if ((flags & (1 << IDX_SETTINGS_MAX_FRAME_SIZE)) ===
-      (1 << IDX_SETTINGS_MAX_FRAME_SIZE)) {
+    (1 << IDX_SETTINGS_MAX_FRAME_SIZE)) {
     holder.maxFrameSize =
       settingsBuffer[IDX_SETTINGS_MAX_FRAME_SIZE];
   }
 
   if ((flags & (1 << IDX_SETTINGS_MAX_CONCURRENT_STREAMS)) ===
-      (1 << IDX_SETTINGS_MAX_CONCURRENT_STREAMS)) {
+    (1 << IDX_SETTINGS_MAX_CONCURRENT_STREAMS)) {
     holder.maxConcurrentStreams =
       settingsBuffer[IDX_SETTINGS_MAX_CONCURRENT_STREAMS];
   }
 
   if ((flags & (1 << IDX_SETTINGS_MAX_HEADER_LIST_SIZE)) ===
-      (1 << IDX_SETTINGS_MAX_HEADER_LIST_SIZE)) {
+    (1 << IDX_SETTINGS_MAX_HEADER_LIST_SIZE)) {
     holder.maxHeaderListSize =
       settingsBuffer[IDX_SETTINGS_MAX_HEADER_LIST_SIZE];
   }
 
   if ((flags & (1 << IDX_SETTINGS_ENABLE_CONNECT_PROTOCOL)) ===
-      (1 << IDX_SETTINGS_ENABLE_CONNECT_PROTOCOL)) {
+    (1 << IDX_SETTINGS_ENABLE_CONNECT_PROTOCOL)) {
     holder.enableConnectProtocol =
       settingsBuffer[IDX_SETTINGS_ENABLE_CONNECT_PROTOCOL];
   }
@@ -387,7 +387,6 @@ function getStreamState(stream) {
 
 function isIllegalConnectionSpecificHeader(name, value) {
   switch (name) {
-    case HTTP2_HEADER_CONNECTION:
     case HTTP2_HEADER_UPGRADE:
     case HTTP2_HEADER_HOST:
     case HTTP2_HEADER_HTTP2_SETTINGS:
@@ -425,7 +424,7 @@ function assertValidPseudoHeaderTrailer(key) {
 }
 
 function mapToHeaders(map,
-                      assertValuePseudoHeader = assertValidPseudoHeader) {
+  assertValuePseudoHeader = assertValidPseudoHeader) {
   let ret = '';
   let count = 0;
   const keys = Object.keys(map);
@@ -470,15 +469,22 @@ function mapToHeaders(map,
         throw err;
       ret = `${key}\0${value}\0${ret}`;
       count++;
-      continue;
-    }
-    if (isIllegalConnectionSpecificHeader(key, value)) {
-      throw new ERR_HTTP2_INVALID_CONNECTION_HEADERS(key);
-    }
-    if (isArray) {
-      for (var k = 0; k < value.length; k++) {
-        const val = String(value[k]);
-        ret += `${key}\0${val}\0`;
+    } else {
+      if (isIllegalConnectionSpecificHeader(key, value)) {
+        return new ERR_HTTP2_INVALID_CONNECTION_HEADERS(key);
+      }
+      if (isArray) {
+        for (var k = 0; k < value.length; k++) {
+          const val = String(value[k]);
+          ret += `${key}\0${val}\0`;
+        }
+        count += value.length;
+      }
+      else if (key === HTTP2_HEADER_CONNECTION) {
+        headerMessageWarn(key);
+      } else {
+        ret += `${key}\0${value}\0`;
+        count++;
       }
       count += value.length;
       continue;
@@ -501,9 +507,9 @@ class NghttpError extends Error {
 
 function assertIsObject(value, name, types = 'Object') {
   if (value !== undefined &&
-      (value === null ||
-       typeof value !== 'object' ||
-       Array.isArray(value))) {
+    (value === null ||
+      typeof value !== 'object' ||
+      Array.isArray(value))) {
     const err = new ERR_INVALID_ARG_TYPE(name, types, value);
     Error.captureStackTrace(err, assertIsObject);
     throw err;
@@ -512,7 +518,7 @@ function assertIsObject(value, name, types = 'Object') {
 
 function assertWithinRange(name, value, min = 0, max = Infinity) {
   if (value !== undefined &&
-      (typeof value !== 'number' || value < min || value > max)) {
+    (typeof value !== 'number' || value < min || value > max)) {
     const err = new ERR_HTTP2_INVALID_SETTING_VALUE.RangeError(name, value);
     err.min = min;
     err.max = max;
@@ -581,6 +587,14 @@ function sessionName(type) {
   }
 }
 
+function headerMessageWarn(key) {
+  process.emitWarning(
+    `The provided header "${key}" is not valid, ` +
+    'and is supported only for compatibility.',
+    'UnsupportedWarning'
+  );
+}
+
 module.exports = {
   assertIsObject,
   assertValidPseudoHeaderResponse,

lib/internal/util/inspect.js

@@ -163,8 +163,6 @@ function inspect(value, opts) {
     colors: inspectDefaultOptions.colors,
     customInspect: inspectDefaultOptions.customInspect,
     showProxy: inspectDefaultOptions.showProxy,
-    // TODO(BridgeAR): Deprecate `maxArrayLength` and replace it with
-    // `maxEntries`.
     maxArrayLength: inspectDefaultOptions.maxArrayLength,
     breakLength: inspectDefaultOptions.breakLength,
     compact: inspectDefaultOptions.compact,

lib/internal/worker.js

@@ -453,7 +453,8 @@ function setupChild(evalScript) {
       port.unref();
       port.postMessage({ type: messageTypes.UP_AND_RUNNING });
       if (doEval) {
-        evalScript('[worker eval]', filename);
+        const src = `'use strict'; ${filename}`;
+        evalScript('[worker eval]', src);
       } else {
         process.argv[1] = filename; // script filename
         require('module').runMain();

src/node_config.cc

@@ -77,9 +77,6 @@ static void Initialize(Local<Object> target,
   if (env->options()->experimental_repl_await)
     READONLY_TRUE_PROPERTY(target, "experimentalREPLAwait");
 
-  if (env->options()->pending_deprecation)
-    READONLY_TRUE_PROPERTY(target, "pendingDeprecation");
-
   if (env->options()->expose_internals)
     READONLY_TRUE_PROPERTY(target, "exposeInternals");