Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] cli: add --max-http-header-size flag #25168

Closed
wants to merge 3 commits into from
Closed

[v10.x] cli: add --max-http-header-size flag #25168

wants to merge 3 commits into from

Commits on Dec 21, 2018

  1. deps: cherry-pick http_parser_set_max_header_size 

    This commit adds http_parser_set_max_header_size() to the
http-parser for overriding the compile time maximum HTTP
header size.

PR-URL: nodejs#24811
Fixes: nodejs#24692
Refs: nodejs/http-parser#453
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @cjihrig @MylesBorins
    cjihrig authored and MylesBorins committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    0c334f8 View commit details
    Browse the repository at this point in the history

  2. src: add kUInteger parsing 

    This commit adds support for uint64_t option parsing.

PR-URL: nodejs#24811
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @mcollina @MylesBorins
    mcollina authored and MylesBorins committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    25c5d39 View commit details
    Browse the repository at this point in the history

  3. cli: add --max-http-header-size flag 

    Allow the maximum size of HTTP headers to be overridden from
the command line.

co-authored-by: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs#24811
Fixes: nodejs#24692
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @cjihrig @mcollina @MylesBorins
    2 people authored and MylesBorins committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    0f63248 View commit details
    Browse the repository at this point in the history