Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use std::vector for setting up process.execPath #25069

Closed
wants to merge 1 commit into from
Closed

src: use std::vector for setting up process.execPath #25069

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Dec 15, 2018 •
edited
Loading

Whitespace-adjusted diff for review: https://github.com/nodejs/node/pull/25069/files?w=1

Use std::vector as an RAII-style alternative to allocating
and deleting raw memory storage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: use std::vector for setting up process.execPath
793eb52 
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1966/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 15, 2018
@richardlau
Copy link
Member

Commit message linter failure is bogus. Have opened nodejs/core-validate-commit#40.

@TimothyGu
Copy link
Member

Is there a reason why we can't statically allocate the memory, given that PATH_MAX is known at compile-time?

@danbev
Copy link
Contributor

danbev commented Dec 20, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19688/ ✔️

@danbev
Copy link
Contributor

danbev commented Dec 21, 2018

Landed in 0461e4c.

@danbev danbev closed this Dec 21, 2018
pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Dec 21, 2018
@addaleax @danbev
src: use std::vector for setting up process.execPath
0461e4c 
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

PR-URL: nodejs#25069
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@addaleax @MylesBorins
src: use std::vector for setting up process.execPath
3dcdfe3 
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

PR-URL: #25069
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@addaleax @MylesBorins
src: use std::vector for setting up process.execPath
b801b03 
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

PR-URL: #25069
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
src: use std::vector for setting up process.execPath
0464856 
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

PR-URL: nodejs#25069
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @nodejs-github-bot @richardlau @TimothyGu @danbev @jasnell @lpinca @cjihrig @joyeecheung @BethGriggs