util: inspect all prototypes #24974
Closed
util: inspect all prototypes #24974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
It is currently difficult to distinguish multiple objects from each other because the prototype is not properly inspected. From now on all prototypes will be inspected, even if we do not fully know how they will look like / what their shape really is. Fixes: nodejs#24917
BridgeAR
force-pushed
the
inspect-weird-prototypes
branch
from
6323832 to
5a2cc3a
Compare
lpinca
approved these changes
Dec 12, 2018
|
Does the test case in #24917 now produces an error message that starts with for both variants? |
|
@lpinca correct. With this solution prototypes will almost always be properly distinguishable. There are a few edge cases left where that's not the case but they should be negligible. It's just hard to guarantee that different inputs will actually also produce a different output. |
BridgeAR
added
the
author ready
|
Resume Build CI: https://ci.nodejs.org/job/node-test-commit/24292/ ✔️ |
|
@nodejs/util PTAL. I would like to get another review for this one. |
jasnell
approved these changes
Dec 15, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Dec 16, 2018
It is currently difficult to distinguish multiple objects from each other because the prototype is not properly inspected. From now on all prototypes will be inspected, even if we do not fully know how they will look like / what their shape really is. PR-URL: nodejs#24974 Fixes: nodejs#24917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 02b66b5 |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
It is currently difficult to distinguish multiple objects from each other because the prototype is not properly inspected. From now on all prototypes will be inspected, even if we do not fully know how they will look like / what their shape really is. PR-URL: #24974 Fixes: #24917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
It is currently difficult to distinguish multiple objects from each other because the prototype is not properly inspected. From now on all prototypes will be inspected, even if we do not fully know how they will look like / what their shape really is. PR-URL: nodejs#24974 Fixes: nodejs#24917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently difficult to distinguish multiple objects from each
other because the prototype is not properly inspected. From now on
all prototypes will be inspected, even if we do not fully know how
they will look like / what there shape really is.
Fixes: #24917
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes