process: properly close file descriptor on exit #24972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit.
nodejs-github-bot
added
the
process
4 tasks
Fishrock123
approved these changes
Dec 12, 2018
BridgeAR
added
the
author ready
addaleax
approved these changes
Dec 12, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19497/ |
|
AIX failures in CI were one known issue (#24921) that @gireeshpunathil is investigated but is currently awaiting access to the relevant AIX host (nodejs/build#1637), and one issue that I don't think is new but hasn't been reported to track it so I opened an issue (#25029). Will open a PR to mark as flaky if they persist. In the meantime.... Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19503/ ✔️ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 14, 2018
This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: nodejs#24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 80ab537 |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: #24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: nodejs#24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: #24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: #24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: #24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the file descriptor is closed syncronously on exit
instead of using the asyncronous version which should not be used
on exit.
This is pulled out from #24965 as suggested by @addaleax.
Refs: https://github.com/nodejs/node/pull/24965/files#r240770314
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes