-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: ensure readable stream flows to end #24918
Closed
Closed
Commits on Dec 9, 2018
-
lib: ensure readable stream flows to end
If a readable stream was set up with `highWaterMark 0`, the while-loop in `maybeReadMore_` function would never execute. The while loop now has an extra or-condition for the case where the stream is flowing and there are no items. The or-condition is adapted from the emit-condition of the `addChunk` function. The `addChunk` also contains a check for `state.sync`. However that part of the check was omitted here because the `maybeReadMore_` is executed using `process.nextTick`. `state.sync` is set and then unset within the `read()` function so it should never be in effect in `maybeReadMore_`. Fixes: nodejs#24915
Configuration menu - View commit details
-
Copy full SHA for 6685360 - Browse repository at this point
Copy the full SHA 6685360View commit details
Commits on Dec 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a7cc7a3 - Browse repository at this point
Copy the full SHA a7cc7a3View commit details
Commits on Dec 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a293112 - Browse repository at this point
Copy the full SHA a293112View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d230ab - Browse repository at this point
Copy the full SHA 5d230abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cb1ccc - Browse repository at this point
Copy the full SHA 7cb1cccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30f6a50 - Browse repository at this point
Copy the full SHA 30f6a50View commit details
Commits on Dec 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 216f5e0 - Browse repository at this point
Copy the full SHA 216f5e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2ab091 - Browse repository at this point
Copy the full SHA f2ab091View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.