Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: ensure readable stream flows to end #24918

Closed
wants to merge 8 commits into from

Commits on Dec 9, 2018

  1. lib: ensure readable stream flows to end

    If a readable stream was set up with `highWaterMark 0`, the while-loop
    in `maybeReadMore_` function would never execute.
    
    The while loop now has an extra or-condition for the case where the
    stream is flowing and there are no items. The or-condition is adapted
    from the emit-condition of the `addChunk` function.
    
    The `addChunk` also contains a check for `state.sync`. However that part
    of the check was omitted here because the `maybeReadMore_` is executed
    using `process.nextTick`. `state.sync` is set and then unset  within the
    `read()` function so it should never be in effect in `maybeReadMore_`.
    
    Fixes: nodejs#24915
    Rantanen committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    6685360 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Configuration menu
    Copy the full SHA
    a7cc7a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Configuration menu
    Copy the full SHA
    a293112 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d230ab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7cb1ccc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    30f6a50 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. Configuration menu
    Copy the full SHA
    216f5e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2ab091 View commit details
    Browse the repository at this point in the history