Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix wrong parameter #24844

Closed
wants to merge 1 commit into from
Closed

test: fix wrong parameter #24844

wants to merge 1 commit into from

Conversation

zhmushan
Copy link
Contributor

@zhmushan zhmushan commented Dec 5, 2018

the expected result should be \

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 5, 2018
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone else wondering: The loop that runs the tests detects if path.win32.join() is being used and, if so, allows / in the expected result to be \ instead. It does this so that the generic tests can run on both POSIX and Windows. So, that's why the test works with and without this change.

@Trott
Copy link
Member

Trott commented Dec 5, 2018

@Trott
Copy link
Member

Trott commented Dec 8, 2018

Landed in 008b904.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 8, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 8, 2018
PR-URL: nodejs#24844
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@zhmushan zhmushan deleted the fix-test-path-join branch December 8, 2018 22:02
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
PR-URL: #24844
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24844
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24844
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
PR-URL: #24844
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24844
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants