Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: streamline Accepting Modifications in Collaborator Guide #24807

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 3, 2018

Editing a sentence I missed simplifying in the last pass on that
section.

Collaborators, 👍 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Editing a sentence I missed simplifying in the last pass on that
section.
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 3, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 3, 2018
@vsemozhetbyt vsemozhetbyt added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project. labels Dec 3, 2018
@Trott
Copy link
Member Author

Trott commented Dec 3, 2018

Landed in 2e03b76

@Trott Trott closed this Dec 3, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 3, 2018
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: nodejs#24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: nodejs#24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@Trott Trott deleted the simplify-guide branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants