Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prepare test/pseudo-tty/testcfg.py for Python 3 #24791

Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 2, 2018

label: python

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Dec 2, 2018
@cclauss cclauss force-pushed the Py3-for-test_pseudo-tty-testcfg.py branch from 8b90890 to 2abb72e Compare December 3, 2018 08:41
@cclauss cclauss changed the title Python 3 prep for test/pseudo-tty/testcfg.py @cclauss test: prepare test/pseudo-tty/testcfg.py for Python 3 Dec 3, 2018
@cclauss cclauss changed the title @cclauss test: prepare test/pseudo-tty/testcfg.py for Python 3 test: prepare test/pseudo-tty/testcfg.py for Python 3 Dec 3, 2018
@Trott
Copy link
Member

Trott commented Dec 7, 2018

@Trott
Copy link
Member

Trott commented Dec 7, 2018

@nodejs/python This could use another reviewer.

@Trott
Copy link
Member

Trott commented Dec 7, 2018

Landed in 6028f70

@Trott Trott closed this Dec 7, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 7, 2018
PR-URL: nodejs#24791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cclauss cclauss deleted the Py3-for-test_pseudo-tty-testcfg.py branch December 7, 2018 06:59
MylesBorins pushed a commit that referenced this pull request Dec 7, 2018
PR-URL: #24791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
PR-URL: #24791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants