Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix order of events when request is aborted #24779

Closed
wants to merge 1 commit into from
Closed

doc: fix order of events when request is aborted #24779

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Dec 2, 2018

Checklist

@nodejs-github-bot
Copy link
Collaborator

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1792/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Dec 2, 2018
addaleax
addaleax approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/http

@lpinca
Copy link
Member Author

lpinca commented Dec 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1868/

lpinca added a commit to lpinca/node that referenced this pull request Dec 8, 2018
@lpinca
doc: fix order of events when request is aborted
63469ed 
PR-URL: nodejs#24779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@lpinca
Copy link
Member Author

lpinca commented Dec 8, 2018

Landed in 63469ed.

@lpinca lpinca closed this Dec 8, 2018
@lpinca lpinca deleted the fix/order-of-events branch December 8, 2018 14:31
targos pushed a commit that referenced this pull request Dec 8, 2018
@lpinca @targos
doc: fix order of events when request is aborted
643ca14 
PR-URL: #24779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@lpinca @refack
doc: fix order of events when request is aborted
01156be 
PR-URL: nodejs#24779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@lpinca @BethGriggs
doc: fix order of events when request is aborted
e9ad526 
PR-URL: #24779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@lpinca @BethGriggs
doc: fix order of events when request is aborted
d972f28 
PR-URL: #24779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@lpinca @rvagg
doc: fix order of events when request is aborted
56c02c5 
PR-URL: #24779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@addaleax addaleax addaleax approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lpinca @nodejs-github-bot @danbev @addaleax @trivikr @BethGriggs