Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x backport] doc: sort markdown refs in errors #24678

Closed
Closed
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
24dd67f
build: configure default v8_optimized_debug
refack Oct 16, 2018
c9ecaef
deps,v8: fix gypfile bug
refack Oct 15, 2018
a1b5643
build: add -Werror=undefined-inline to clang builds
refack Oct 29, 2018
6f249bc
src: fix fully-static & large-pages combination
suresh-srinivas Oct 29, 2018
cc72b2a
build: make benchmark/napi all prereq order-only
danbev Oct 29, 2018
9be73ea
doc: add types and their corresponding return values
oyyd Oct 31, 2018
f1f1ae4
doc: improve BUILDING.md
jagannathBhat Oct 30, 2018
00c0539
doc: improve COLLABORATOR_GUIDE
jagannathBhat Oct 30, 2018
0ca3646
test: fix test-fs-watch-system-limit
ofrobots Oct 30, 2018
db4f92d
child_process: handle undefined/null for fork() args
shobhitchittora Aug 20, 2018
0ed9aaa
test: add property for RangeError in test-buffer-copy
mritunjayz Oct 30, 2018
e0902c8
test: fix strictEqual arguments order
Westixy Oct 29, 2018
3c314d1
test: assert that invalidcmd throws error code
jeromecovington Oct 28, 2018
add267b
tools: update alternative docs versions
richardlau Oct 30, 2018
559ce1c
doc: revise CHANGELOG.md text
Trott Oct 31, 2018
1956800
doc: simplify CODE_OF_CONDUCT.md
Trott Oct 31, 2018
e8e5926
doc: revise COLLABORATOR_GUIDE.md
Trott Oct 31, 2018
0c923cf
doc: address bits of proof reading work
jagannathBhat Oct 30, 2018
579bcd1
doc: fix dublication in net.createServer() docs
prog1dev Nov 1, 2018
24a5c56
deps: cherry-pick 2987946 from upstream V8
refack Nov 21, 2018
d9e10fb
build: only check REPLACEME & DEP...X for releases
rvagg May 11, 2017
17eaf1b
test: increase --stack_size test-async-wrap-pop
danbev Oct 31, 2018
00badcb
fs: handle result of access binding directly in fs.existsSync
joyeecheung Nov 1, 2018
06844e8
n-api: add missing handle scopes
danbev Oct 31, 2018
e5177e9
repl: use promise#finally
starkwang Oct 30, 2018
7f0c3bb
doc: edit man page for superfluous "node" usage
Trott Nov 2, 2018
4fb93d1
doc: add SECURITY.md to readme.md
warnerp18 Nov 2, 2018
40c3752
doc: fix socket.connecting description
addaleax Nov 3, 2018
0ad9103
tools: add script to lint first PR commit message
richardlau Nov 2, 2018
f6a48d6
doc: correct link to test coverage command
mritunjayz Nov 2, 2018
aebd6d9
doc: add missing comma in net documentation
Trott Nov 4, 2018
9b55b90
build: do not lint on non-PR Travis builds
addaleax Nov 4, 2018
b09f94c
build: fix Travis non-PR builds
richardlau Nov 5, 2018
a23ab00
doc: add table of contents to release guide
targos Nov 2, 2018
3afde80
doc: streamline CONTRIBUTING.md
Trott Nov 1, 2018
a93a1df
meta,doc: ping community about new release
refack Nov 3, 2018
4cb822e
lib: move module exports proxy into a separate method
joyeecheung Nov 3, 2018
cc82efa
net: `net.Server.listen()` avoid operations on `null` when fail
oyyd Oct 27, 2018
bb4c086
lib:fix grammar error and make it clearer for comments
Oct 21, 2018
d30e573
test: add crypto check to test-benchmark-http2
danbev Nov 5, 2018
290796f
doc: fix minor text issues in stream.md
Trott Nov 6, 2018
a77dc9a
doc: inspector security warning for changing host
ChALkeR Oct 13, 2018
3999710
vm: clarify timeout option in vm
vdeturckheim Oct 12, 2018
45a3278
doc: implement minor text fixes to path.md
Trott Nov 6, 2018
4eaab7c
deps: remove old c-ares configure files
bnoordhuis Oct 24, 2018
209b1d5
deps: upgrade to c-ares v1.15.0
bnoordhuis Oct 24, 2018
d89bae8
deps: c-ares float, version number patch
bnoordhuis Oct 24, 2018
61458c4
build,meta: don't fail Travis for commit message
refack Oct 18, 2018
f80423b
doc: add shisama to collaborators
Nov 6, 2018
2983df8
build: use latest node on travis
cjihrig Nov 6, 2018
d242a66
doc: add psmarshall to collaborators
psmarshall Nov 6, 2018
f20bf8c
test: disable color formating for test-internal-errors.js
refack Nov 6, 2018
3102bce
doc: update System Errors documentation
Trott Nov 4, 2018
c4e34cc
doc: add text about error.code stability
Trott Nov 4, 2018
0e121bf
doc: wrap GOVERNANCE.md at 80 characters
Trott Nov 5, 2018
2015712
tools: enable 80-char line length markdown linting
Trott Nov 5, 2018
219040d
doc: fix linting errors
cjihrig Nov 7, 2018
a273da9
src: prefer param function check over args length
codebytere Nov 6, 2018
6936060
build: change repo to https protocol in Makefile
mritunjayz Nov 4, 2018
4cc8ec2
doc: sort markdown refs in errors
sam-github Oct 29, 2018
2a9f701
fixup! doc: sort markdown refs in errors
sam-github Nov 30, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: improve BUILDING.md
PR-URL: #23976
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
jagannathBhat authored and MylesBorins committed Nov 29, 2018
commit f1f1ae4387e2c8835b8317e5bcdb01a7d7f37c2d
16 changes: 8 additions & 8 deletions BUILDING.md
Original file line number Diff line number Diff line change
@@ -95,8 +95,8 @@ platforms in production.
by Joyent. SmartOS images >= 16.4 are not supported because
GCC 4.8 runtime libraries are not available in their pkgsrc repository

<em id="fn2">2</em>: Tier 1 support for building on Windows is only on 64 bit
hosts. Support is experimental for 32 bit hosts.
<em id="fn2">2</em>: Tier 1 support for building on Windows is only on 64-bit
hosts. Support is experimental for 32-bit hosts.

<em id="fn3">3</em>: On Windows, running Node.js in Windows terminal emulators
like `mintty` requires the usage of [winpty](https://github.com/rprichard/winpty)
@@ -114,7 +114,7 @@ platforms in production.

### Supported toolchains

Depending on host platform, the selection of toolchains may vary.
Depending on the host platform, the selection of toolchains may vary.

#### Unix

@@ -126,11 +126,11 @@ Depending on host platform, the selection of toolchains may vary.

#### Windows

* Visual Studio 2017 with the Windows 10 SDK on a 64 bit host.
* Visual Studio 2017 with the Windows 10 SDK on a 64-bit host.

#### OpenSSL asm support

OpenSSL-1.1.0 requires the following asssembler version for use of asm
OpenSSL-1.1.0 requires the following assembler version for use of asm
support on x86_64 and ia32.

* gas (GNU assembler) version 2.23 or higher
@@ -314,7 +314,7 @@ These core dumps are useful for debugging when provided with the
corresponding original debug binary and system information.

Reading the core dump requires `gdb` built on the same platform the core dump
was captured on (i.e. 64 bit `gdb` for `node` built on a 64 bit system, Linux
was captured on (i.e. 64-bit `gdb` for `node` built on a 64-bit system, Linux
`gdb` for `node` built on Linux) otherwise you will get errors like
`not in executable format: File format not recognized`.

@@ -433,7 +433,7 @@ $ ./configure --without-intl
$ pkg-config --modversion icu-i18n && ./configure --with-intl=system-icu
```

If you are cross compiling, your `pkg-config` must be able to supply a path
If you are cross-compiling, your `pkg-config` must be able to supply a path
that works for both your host and target environments.

#### Build with a specific ICU:
@@ -481,7 +481,7 @@ This version of Node.js does not support FIPS.
## Building Node.js with external core modules

It is possible to specify one or more JavaScript text files to be bundled in
the binary as builtin modules when building Node.js.
the binary as built-in modules when building Node.js.

### Unix/macOS