Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-uv-binding-constant JS engine neutral #24666

Closed
wants to merge 1 commit into from
Closed

test: make test-uv-binding-constant JS engine neutral #24666

wants to merge 1 commit into from

Commits on Nov 27, 2018

  1. test: make test-uv-binding-constant JS engine neutral 

    The error message validation in test-uv-binding-constant depends on the
JS engine. The text will be different in node-chakracore than in
V8-based versions of Node.js. Remove the message validation. Test that
it is a TypeError only. We should only validate error messages when we
control the contents of that error message (and not even necessarily
then, but that is a minimum requirement). V8 and other underlying
engines can change the error message at any time and that should not
require us to change our tests (as changing tests suggests a
semver-major change).
    @Trott
    Trott committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    562b923 View commit details
    Browse the repository at this point in the history