Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix replace anonymous function with arrow function #24606

Closed
wants to merge 2 commits into from
Closed

docs: fix replace anonymous function with arrow function #24606

wants to merge 2 commits into from

Conversation

taminif
Copy link
Contributor

@taminif taminif commented Nov 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Nov 24, 2018
@shisama shisama added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Nov 24, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With nit that can be fixed on landing.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1693/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 24, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 24, 2018 •
edited
Loading

@taminif It seems the email in your commit is not included in your GitHub settings. From our contributing guide:

If you would like for the Github UI to link the commit to your account and award you the Contributor label after the changes have been merged, make sure this local email is also added to your GitHub email list.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 24, 2018
@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 25, 2018
@Trott
Copy link
Member

Trott commented Nov 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18955/

@taminif
Copy link
Contributor Author

taminif commented Nov 25, 2018

@vsemozhetbyt Sorry I checked email. I didn't have much time to fixed reviews.
I will take care in next PRs. thanks!

@Trott Thanks for fixing bug!

@targos
Copy link
Member

targos commented Nov 25, 2018

Please remove "anonymous" from the commit message while landing. The functions previously were not anonymous.

@targos targos mentioned this pull request Nov 25, 2018
Closed
@gireeshpunathil
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-commit/23633/

@Trott
Copy link
Member

Trott commented Nov 26, 2018

Landed in e958ee7

@Trott Trott closed this Nov 26, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 26, 2018
@Trott
doc: use arrow function for anonymous callbacks
e958ee7 
PR-URL: nodejs#24606
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott
Copy link
Member

Trott commented Nov 26, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Nov 27, 2018
@targos
doc: use arrow function for anonymous callbacks
c948a2d 
PR-URL: #24606
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rvagg
doc: use arrow function for anonymous callbacks
b65ffd5 
PR-URL: #24606
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
@beevelop beevelop mentioned this pull request Dec 7, 2018
Closed
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
doc: use arrow function for anonymous callbacks
89c5278 
PR-URL: nodejs#24606
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@BethGriggs
doc: use arrow function for anonymous callbacks
a1a393b 
PR-URL: #24606
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
doc: use arrow function for anonymous callbacks
4c85197 
PR-URL: #24606
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronkorving ronkorving ronkorving approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@taminif @vsemozhetbyt @Trott @targos @gireeshpunathil @ronkorving @joyeecheung @BethGriggs @shisama @nodejs-github-bot