switch lib/readline.js to arrow functions

[dominikeinkemmer]

Refs: nodejsjp#1

fix function declarations to arrow functions inside of lib/readline.js where possible

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[gireeshpunathil]

CI: https://ci.nodejs.org/job/node-test-pull-request/18928/

[gireeshpunathil]

fast-track? pls 👍
edit: api code; no fast-tracking

[dominikeinkemmer]

Hey guys, travis-ci keeps saying the first line of my commit message doesn't follow the guidelines, but I don't understand what is wrong about it, can someone check and let me know? 🙇

[gireeshpunathil]

here is your commit message:

    lib: convert lib/readline.js to arrow functions
    
    fix function declarations to arrow functions inside of lib/readline.js where possible

error with that is, the second line exceeds 72 characters: https://travis-ci.com/nodejs/node/jobs/160709756#L712

ref: https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines

you could either:

• git rebase -i and reword that opens up the editor for amending the commit or
• leave it as it is for folks who land this to fix it.

[Trott]

Hey guys, travis-ci keeps saying the first line of my commit message doesn't follow the guidelines

Oooh, I never noticed that the line listing is 0-indexed. So line 1 is the second line. IMO that's a bug in core-validate-commit that we should fix.

I'll fix the commit message while landing.

[Trott]

I'll fix the commit message while landing.

Oops, no I won't because commits have been pushed since last CI, so CI needs to run again. If you want to fix it yourself, that would be awesome. In the meantime, the landing process is stalled until CI becomes available again (which should be in a few hours).

[Trott]

It looks like you already have a good contribution in the Node.js condebase and this is kind of a neutral change. Honestly, I wonder if we should close it? Especially since it's in lib, not sure churn is helpful?

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/18990/

[Trott]

I'm going to close this. I can't bring myself to land it because it doesn't seem to improve the code base to me. I don't like to do that to new contributors, but you do have a commit that landed, so 🎉. And if some other Collaborator feels strongly that this should land, please feel free to disregard my opinion on this, re-open, and land.

@dominikeinkemmer Thanks for the PR! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)