Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch lib/readline to arrow functions #24599

Closed
wants to merge 1 commit into from
Closed

switch lib/readline to arrow functions #24599

wants to merge 1 commit into from

Conversation

dominikeinkemmer
Copy link
Contributor

Refs: nodejsjp#1

fix function declarations to arrow functions inside of lib/readline.js where possible

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dominikeinkemmer
switch to arrow functions
685bd1d 
fix function declarations to arrow functions inside of lib/readline.js where possible
@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Nov 24, 2018
@dominikeinkemmer dominikeinkemmer changed the title switch to arrow functions switch lib/readline to arrow functions Nov 24, 2018
@ronkorving ronkorving added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@dominikeinkemmer dominikeinkemmer deleted the covert-to-arrow-function-readline branch November 24, 2018 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikeinkemmer @ronkorving @nodejs-github-bot