Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix assert.strictEqual #24594

Closed
wants to merge 1 commit into from
Closed

test: fix assert.strictEqual #24594

wants to merge 1 commit into from

Conversation

hyokenmi
Copy link

@hyokenmi hyokenmi commented Nov 24, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2018
@ronkorving ronkorving added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

looks like #24592 also addresses the same file. can you please discuss with @na9amura and probably pick up another assignment?

@Trott
Copy link
Member

Trott commented Nov 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18948/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2018
@gireeshpunathil
Copy link
Member

looks like @24592 and #24610 were closed in favor of this; so all set for this PR. fast-track? pls 👍

@Trott
Copy link
Member

Trott commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18971/

@Trott
Copy link
Member

Trott commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18976/

@Trott
Copy link
Member

Trott commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18981/

@Trott
Copy link
Member

Trott commented Nov 28, 2018

Landed in 46094e4.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@Trott
test: fix argument order in assert.strictEqual
46094e4 
PR-URL: nodejs#24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@hyokenmi hyokenmi deleted the bugfix-test-child-process-cwd branch November 28, 2018 11:57
targos pushed a commit that referenced this pull request Nov 28, 2018
@targos
test: fix argument order in assert.strictEqual
3b99191 
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
test: fix argument order in assert.strictEqual
879a8c3 
PR-URL: nodejs#24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
test: fix argument order in assert.strictEqual
ec7bd18 
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
test: fix argument order in assert.strictEqual
73cfbb0 
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Leko Leko Leko approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hyokenmi @gireeshpunathil @Trott @addaleax @Leko @cjihrig @ronkorving @BethGriggs @nodejs-github-bot