Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: simplify uptime and ppid return values #24562

Closed
wants to merge 1 commit into from
Closed

src: simplify uptime and ppid return values #24562

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 22, 2018 •
edited
Loading

This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

EDIT: Yellow CI - https://ci.nodejs.org/job/node-test-pull-request/18912/

@cjihrig
src: simplify uptime and ppid return values
06202c0 
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1673/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 22, 2018
bnoordhuis
bnoordhuis approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so that's where the other PR got it from. :-)

@danbev
Copy link
Contributor

danbev commented Nov 27, 2018

Landed in 11c17e4.

@danbev danbev closed this Nov 27, 2018
danbev pushed a commit that referenced this pull request Nov 27, 2018
@cjihrig @danbev
src: simplify uptime and ppid return values
11c17e4 
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

PR-URL: #24562
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@cjihrig cjihrig deleted the return-values branch November 27, 2018 15:01
targos pushed a commit that referenced this pull request Nov 27, 2018
@cjihrig @targos
src: simplify uptime and ppid return values
29e6a0e 
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

PR-URL: #24562
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@cjihrig @rvagg
src: simplify uptime and ppid return values
9caad06 
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

PR-URL: #24562
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
src: simplify uptime and ppid return values
c1d374d 
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

PR-URL: nodejs#24562
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@cjihrig @BethGriggs
src: simplify uptime and ppid return values
28a1cc1 
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

PR-URL: #24562
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig @rvagg
src: simplify uptime and ppid return values
dfd3c58 
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

PR-URL: #24562
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@maclover7 maclover7 maclover7 approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @danbev @refack @bnoordhuis @maclover7 @richardlau @BethGriggs