Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise author ready explanation #24558

Closed
wants to merge 1 commit into from
Closed

doc: revise author ready explanation #24558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,15 @@ issues and pull requests can always be re-opened if necessary.

### Author ready pull requests

A pull request that is still awaiting the minimum review time is considered
_author ready_ as soon as the CI has been started, it has at least two approvals
(one Collaborator approval is enough if the pull request has been open for more
than 7 days), and it has no outstanding review comments. Please always make sure
to add the `author ready` label to the PR in that case and remove it again as
soon as that condition is not met anymore.
A pull request is _author ready_ when:

* There is a CI run in progress or completed.
* There are at least two Collaborator approvals, or at least one approval if the
pull request is older than 7 days.
* There are no outstanding review comments.

Please always add the `author ready` label to the PR in that case. Please always
remove it again as soon as the conditions are not met anymore.

### Handling own pull requests

Expand Down