-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: partition N-API tests #24557
test: partition N-API tests #24557
Conversation
cd2fbee
to
5e40521
Compare
@bghgary would this help test your implementation of N-API? |
I scanned the changes, but I'm not familiar with the build/test infrastructure. It looks like it will help. Does this build without my PR? I have been curious why the tests don't catch the header issue that I'm having. |
5e40521
to
5fe7c4d
Compare
@bghgary I guess you're right. We won't really know whether the tests in test/js-native-api will build/run until we try to build/run them out-of-tree. The idea is that nothing in any of the subdirectories of test/js-native-api refers to |
... and then a different |
That would be great! |
Kinda RSLGTM, if it passes CI it's good (binary |
5fe7c4d
to
79fcc8f
Compare
OK, I don't get it. What's wrong with {
"targets": [
{
"target_name": "test_constructor",
"sources": [
"test_constructor.c",
"../entry_point.c"
]
},
{
"target_name": "test_constructor_name",
"sources": [
"test_constructor_name.c",
"../entry_point.c"
]
}
]
} It can't seem to find |
I think it's a GYP limitation. It's not allowed to look outside of the scope of the root (Also if it's possible to create this whole thing as 1 addon with multiple test entry points, that would be great for test run performance, since compiling each addon has a very big time overhead) |
@refack thanks! I hope I can |
Argh! No help. I'll have to try some other way. |
Since I assume it's a GYP limitation, I'll dig into this as soon as possible. |
@refack thanks! I don't understand why it's only happening on some platforms. I would imagine that the version of |
6ffcfe3
to
6bcf65e
Compare
sigh tried sorting the files alphabetically, as strongly encouraged by the gyp doc shrug |
Nope. |
BTW, check this out http://gyp3.org/docs/UserDocumentation.html#add-a-source-file-that-builds-on-all-platforms |
6bcf65e
to
8f0a690
Compare
Lessee if it's only one addon in |
OK, consolidating the two addons into one seems to have done it. |
Refs: nodejs#24557 (comment) PR-URL: nodejs#24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Partition test/addons-napi into test/js-native-api and test/node-api to isolate the Node.js-agnostic portion of the N-API tests from the Node.js-specific portion. PR-URL: #24557 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Partition test/addons-napi into test/js-native-api and test/node-api to isolate the Node.js-agnostic portion of the N-API tests from the Node.js-specific portion. PR-URL: #24557 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Partition test/addons-napi into test/js-native-api and test/node-api to isolate the Node.js-agnostic portion of the N-API tests from the Node.js-specific portion. PR-URL: #24557 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@gabrielschulhof I think this patch is responsible for, or exacerbates, a race condition when running |
Partition test/addons-napi into test/js-native-api and test/node-api to isolate the Node.js-agnostic portion of the N-API tests from the Node.js-specific portion. PR-URL: nodejs#24557 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: nodejs#24557 (comment) PR-URL: nodejs#24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: nodejs#24557 (comment) PR-URL: nodejs#24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Refs: #24557 (comment) PR-URL: #24839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Partition test/addons-napi into test/js-native-api and test/node-api to
isolate the Node.js-agnostic portion of the N-API tests from the
Node.js-specific portion.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes