-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replaced anonymous functions with closuers #24442
Conversation
I suppose it was closed by mistake? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Commit message should look like: test: replace anonymous functions with arrow functions
@rkp1146 - your email is not associated with your GitHub account while you pushed the change. |
fast-track? 👍 |
Resume build CI: https://ci.nodejs.org/job/node-test-commit/23491/ |
failure in windows-fanned seems unrelated. Resume CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22620/ |
the single failure in windows-fanned is unrelated; landing.
|
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes