fs,net: standardize pending stream property
#24067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted.
addaleax
added
fs
nodejs-github-bot
added
dont-land-on-v6.x
http2
mscdex
reviewed
Nov 3, 2018
mscdex
reviewed
Nov 3, 2018
mscdex
reviewed
Nov 3, 2018
|
@mscdex Done, addressed all 3 comments. |
lpinca
reviewed
Nov 3, 2018
|
@lpinca Thanks for catching those, done! |
lpinca
approved these changes
Nov 3, 2018
JungMinu
approved these changes
Nov 4, 2018
sindresorhus
reviewed
Nov 5, 2018
| @@ -488,6 +488,16 @@ argument to `fs.createReadStream()`. If `path` is passed as a string, then | |||
| `readStream.path` will be a string. If `path` is passed as a `Buffer`, then | |||
| `readStream.path` will be a `Buffer`. | |||
|
|
|||
| ### readStream.pending | |||
There was a problem hiding this comment.
Would be better to name this .isPending. When you read .pending, it could either mean it contains a pending object or a boolean of whether it's pending. That's not clear from just reading the code.
There was a problem hiding this comment.
.pending I think fits the style of other pre-existing properties like .connecting
There was a problem hiding this comment.
It’s also what HTTP/2 already uses for this purpose…
|
Any other thoughts/reviewers? |
jasnell
approved these changes
Nov 10, 2018
addaleax
added
the
author ready
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18605/ |
|
Landed in 0e06b35 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 14, 2018
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted. PR-URL: nodejs#24067 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted. PR-URL: #24067 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted. PR-URL: nodejs#24067 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 15, 2018
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted. PR-URL: #24067 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted. PR-URL: #24067 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted. PR-URL: #24067 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted. PR-URL: #24067 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same property name as http2 does to indicate that
the stream is in the state before the
readyevent is emitted.(This is semver-minor. If people feel that we should absolutely not have this in our public API, I’m probably going to incorporate this into a later PR using a Symbol rather than an “official” property.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes