Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix socket.connecting description #24066

Closed
wants to merge 1 commit into from
Closed

doc: fix socket.connecting description #24066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/api/net.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,9 +658,9 @@ called with `{port: port, host: host}` as `options`.
added: v6.1.0
-->

If `true` -
If `true`,
[`socket.connect(options[, connectListener])`][`socket.connect(options)`]
was called and haven't yet finished. Will be set to `false` before emitting
was called and has not yet finished. Will be set to `true` before emitting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro-nit: While we're in here, get rid of yet?

For some other PR perhaps: What does "finished" mean in this context? The connection has not been established? I imagine it doesn't mean that the method is still executing but that is what a naive interpretation might be....

`'connect'` event and/or calling
[`socket.connect(options[, connectListener])`][`socket.connect(options)`]'s
callback.
Expand Down