win: add prompt to tools installation script #23987

joaocgreis · 2018-10-31T03:24:32Z

Since the script to install tools for native modules (#22645) was included in releases, we've got several comments from users surprised by reboots.

This adds a more visible warning and a prompt to lessen the probability of users skipping ahead without reading.

Fixes: nodejs/Release#369

cc @nodejs/platform-windows

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2018-10-31T03:24:34Z

@joaocgreis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1433/pipeline

joaocgreis · 2018-10-31T03:30:51Z

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/18252/ (EDIT: Yellow, one flaky test failed.)

tools/msvs/install_tools/install_tools.bat

+echo Please type YES followed by enter to confirm that you have saved all your
+set /p "ACCEPT_PROMPT=work and closed all open programs: "
+if /i not "%ACCEPT_PROMPT%"=="yes" (
+  echo Please type YES or close the window to exit.


joaocgreis · 2018-10-31T04:55:23Z

@jdalton thanks! Updated.

ferventcoder · 2018-10-31T17:32:10Z

I like the type yes to confirm, but this does not mention the UAC bit - I would like to see the wording from #24000 with this yes prompt

ferventcoder · 2018-10-31T17:36:46Z

Also I missed this was here on initial search and filed my own PR - apologies on that. We would like the wording and notes from the other PR brought into here to address that UAC will be disabled and make the user aware of what they will need to do should they stop the process instead of letting it finish

Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing.

Fixes: nodejs/Release#369

joaocgreis · 2018-10-31T22:00:59Z

@ferventcoder your PR adds a lot of good info, thanks for it! I included it here, let me know if this was not what you had in mind. I took the opportunity to change the commit message (subsystem and 72-col lines) and added a fixup addressing feedback from @Trott. I also moved my prompt to the new screen you created. Let me know if there's any change you'd like to make.

refack · 2018-10-31T23:24:49Z

Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21930/

ferventcoder · 2018-11-01T13:15:21Z

@joaocgreis looks great, thank you!

ferventcoder · 2018-11-01T13:16:11Z

tools/msvs/install_tools/install_tools.bat

+echo in fact it is just a normal Windows Updates reboot cycle.
+echo.
+echo If this is not what you would like to occur, you can close this window
+echo to stop now.


Perhaps we can pull these two lines out since you reference this below.

ferventcoder · 2018-11-01T13:16:52Z

tools/msvs/install_tools/install_tools.bat

+echo Your computer may REBOOT SEVERAL TIMES WITHOUT FURTHER WARNING.
+echo Please type YES followed by enter to confirm that you have saved all your
+set /p "ACCEPT_PROMPT=work and closed all open programs: "
+if /i not "%ACCEPT_PROMPT%"=="yes" (


Does this handle case sensitivity? You are asking for "YES", and this accepts "yes"

The /i switch is for ignoring case. I used uppercase above to make it obvious that only yes needs to be typed, but the user can type in any case.

joaocgreis · 2018-11-01T18:17:03Z

@ferventcoder thanks, updated!

@jdalton this changed a lot since you reviewed. I'll assume your approval still holds, please let me know if not.

joaocgreis · 2018-11-02T04:07:19Z

If there are no objections, I will land this tomorrow.

Full CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/18291/

MylesBorins · 2018-11-14T15:20:19Z

@refack can you open a revert against v10.x-staging

targos · 2018-11-14T15:26:16Z

@MylesBorins: #24344

Notable changes: * deps: * A new experimental HTTP parser (`llhttp`) is now supported. #24059 * timers: * Fixed an issue that could cause setTimeout to stop working as expected. #24322 * Windows * A crashing process will now show the names of stack frames if the node.pdb file is available. #23822 * Continued effort to improve the installer's new stage that installs native build tools. #23987, #24348 * child_process: * On Windows the `windowsHide` option default was restored to `false`. This means `detached` child processes and GUI apps will once again start in a new window. #24034 * Added new collaborators: * [oyyd](https://github.com/oyyd) - Ouyang Yadong. #24300 * [psmarshall](https://github.com/psmarshall) - Peter Marshall. #24170 * [shisama](https://github.com/shisama) - Masashi Hirano. #24136

Notable changes: * deps: * A new experimental HTTP parser (`llhttp`) is now supported. #24059 * timers: * Fixed an issue that could cause setTimeout to stop working as expected. #24322 * Windows * A crashing process will now show the names of stack frames if the node.pdb file is available. #23822 * Continued effort to improve the installer's new stage that installs native build tools. #23987, #24348 * child_process: * On Windows the `windowsHide` option default was restored to `false`. This means `detached` child processes and GUI apps will once again start in a new window. #24034 * Added new collaborators: * [oyyd](https://github.com/oyyd) - Ouyang Yadong. #24300 * [psmarshall](https://github.com/psmarshall) - Peter Marshall. #24170 * [shisama](https://github.com/shisama) - Masashi Hirano. #24136 PR-URL: #24350

This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: nodejs#24344 Refs: nodejs#22645 Refs: nodejs#23987 Refs: nodejs/Release#369 Refs: nodejs#23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing. PR-URL: #23987 Fixes: nodejs/Release#369 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

Fixes: nodejs/Release#369 PR-URL: #23987 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: #24344 Refs: #22645 Refs: #23987 Refs: nodejs/Release#369 Refs: #23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing. PR-URL: #23987 Fixes: nodejs/Release#369 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

Fixes: nodejs/Release#369 PR-URL: #23987 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: #24344 Refs: #22645 Refs: #23987 Refs: nodejs/Release#369 Refs: #23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

joaocgreis added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. dont-land-on-v6.x labels Oct 31, 2018

jdalton reviewed Oct 31, 2018

View reviewed changes

jdalton approved these changes Oct 31, 2018

View reviewed changes

targos mentioned this pull request Oct 31, 2018

Node v11.0 windows installation opting into chocolatey+boxstarter results in infinite reboots #23838

Closed

ferventcoder and others added 3 commits October 31, 2018 21:31

fixup: address feedback from Trott

91d99c6

win: add prompt to tools installation script

23c02c0

Fixes: nodejs/Release#369

joaocgreis force-pushed the joaocgreis-IAV-tools-prompt branch from 300f228 to 23c02c0 Compare October 31, 2018 21:54

joaocgreis mentioned this pull request Oct 31, 2018

doc: clarify Boxstarter behavior on install tools #24000

Closed

2 tasks

refack approved these changes Oct 31, 2018

View reviewed changes

richardlau approved these changes Nov 1, 2018

View reviewed changes

ferventcoder reviewed Nov 1, 2018

View reviewed changes

fixup for d8525d6

078745a

gep13 mentioned this pull request Nov 2, 2018

Rebooted without warning chocolatey/choco#1671

Closed

MPagel mentioned this pull request Nov 13, 2018

added text regarding alternate user elevation. #24343

Closed

4 tasks

BridgeAR mentioned this pull request Nov 14, 2018

Release proposal: v11.2 #24350

Merged

refack added dont-land-on-v10.x and removed land-on-10.x labels Nov 14, 2018

pauby mentioned this pull request Nov 25, 2018

Remove Boxstarter desktop shortcut at uninstall and document uninstall process chocolatey/boxstarter#336

Closed

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

MPagel mentioned this pull request Nov 28, 2018

Startup script may install to the wrong user, causing UAC to remain disabled, especially in AD (Active Directory) environments chocolatey/boxstarter#367

Open

MylesBorins mentioned this pull request Nov 29, 2018

v10.14.1 proposal #24711

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

win: add prompt to tools installation script #23987

win: add prompt to tools installation script #23987

joaocgreis commented Oct 31, 2018

nodejs-github-bot commented Oct 31, 2018

joaocgreis commented Oct 31, 2018 •

edited

Loading

This comment was marked as outdated.

joaocgreis commented Oct 31, 2018

ferventcoder commented Oct 31, 2018

ferventcoder commented Oct 31, 2018

joaocgreis commented Oct 31, 2018

refack commented Oct 31, 2018

ferventcoder commented Nov 1, 2018

ferventcoder Nov 1, 2018

ferventcoder Nov 1, 2018

joaocgreis Nov 1, 2018

joaocgreis commented Nov 1, 2018

joaocgreis commented Nov 2, 2018

MylesBorins commented Nov 14, 2018

targos commented Nov 14, 2018

win: add prompt to tools installation script #23987

win: add prompt to tools installation script #23987

Conversation

joaocgreis commented Oct 31, 2018

Checklist

nodejs-github-bot commented Oct 31, 2018

joaocgreis commented Oct 31, 2018 • edited Loading

This comment was marked as outdated.

joaocgreis commented Oct 31, 2018

ferventcoder commented Oct 31, 2018

ferventcoder commented Oct 31, 2018

joaocgreis commented Oct 31, 2018

refack commented Oct 31, 2018

ferventcoder commented Nov 1, 2018

ferventcoder Nov 1, 2018

Choose a reason for hiding this comment

ferventcoder Nov 1, 2018

Choose a reason for hiding this comment

joaocgreis Nov 1, 2018

Choose a reason for hiding this comment

joaocgreis commented Nov 1, 2018

joaocgreis commented Nov 2, 2018

MylesBorins commented Nov 14, 2018

targos commented Nov 14, 2018

joaocgreis commented Oct 31, 2018 •

edited

Loading